Skip to content

arg : bring back missing ifdef #9411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Conversation

ngxson
Copy link
Collaborator

@ngxson ngxson commented Sep 10, 2024

Ref comment: #9388 (review)

GGML_USE_CUDA_SYCL is not used anywhere, so I remove that too


Copy link
Member

@slaren slaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truthfully these checks are very outdated and other backends now support these settings. Even if not 100% accurate, it would probably be better to replace these checks with a call to llama_supports_gpu_offload.

@ngxson
Copy link
Collaborator Author

ngxson commented Sep 10, 2024

Thanks for the info! I was also wondering if it works on RPC backend.

The llama_supports_gpu_offload should do the trick for now.

@ngxson ngxson merged commit 6cd4e03 into ggml-org:master Sep 10, 2024
52 checks passed
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
* arg : bring back missing ifdef

* replace with llama_supports_gpu_offload
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 15, 2024
* arg : bring back missing ifdef

* replace with llama_supports_gpu_offload
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 18, 2024
* arg : bring back missing ifdef

* replace with llama_supports_gpu_offload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants