fix and speed up compilaton #8354
Open
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unicode-data.cpp takes very long to compile on x86_64 macos with clang 17.0.6 and aarch64 linux GNU 12.2.0 goes OOM on 1GB RAM SBC
|
This will require testing to prove that this change does not affect performance. |
Green-Sky
reviewed
Jul 7, 2024
| @@ -28,3 +28,5 @@ if (BUILD_SHARED_LIBS) | |||
| set_target_properties(llama PROPERTIES POSITION_INDEPENDENT_CODE ON) | |||
| target_compile_definitions(llama PRIVATE LLAMA_SHARED LLAMA_BUILD) | |||
| endif() | |||
|
|
|||
| set_source_files_properties(unicode-data.cpp PROPERTIES COMPILE_FLAGS -O1) | |||
There was a problem hiding this comment.
-O1 is a non-portable compiler flag.
mofosyne
added
the
Review Complexity : Low
|
Yeah unicode takes forever to compile on clang. But fine on gcc for some reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unicode-data.cpp takes very long to compile on x86_64 low powered Mac with clang 17.0.6 and aarch64 linux GNU 12.2.0 goes OOM on 1GB RAM SBC
Review Complexity : Low