Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transient definitions in find pkg #3411

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

bandoti
Copy link
Collaborator

@bandoti bandoti commented Sep 30, 2023

Currently when using find_package(Llama) the transient definitions are not being set, so any hardware acceleration is being ignored. This change fixes that issue by utilizing interface definitions on the imported llama target.

@ggerganov ggerganov merged commit 095231d into ggml-org:master Oct 2, 2023
yusiwen pushed a commit to yusiwen/llama.cpp that referenced this pull request Oct 7, 2023
@bandoti bandoti deleted the fix-cmake-transient-defs branch November 1, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants