Skip to content

Fix metal kernel_norm broken by ca82cf7 #3060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2023
Merged

Fix metal kernel_norm broken by ca82cf7 #3060

merged 2 commits into from
Sep 7, 2023

Conversation

ikawrakow
Copy link
Contributor

No description provided.

@ikawrakow ikawrakow requested a review from ggerganov September 7, 2023 13:20
@ikawrakow ikawrakow changed the title Fix kernel_norm broken by ca82cf7 Fix metal kernel_norm broken by ca82cf7 Sep 7, 2023
@ikawrakow ikawrakow mentioned this pull request Sep 7, 2023
Merged
@ggerganov ggerganov mentioned this pull request Sep 7, 2023
Merged
ggerganov
ggerganov approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. I did push a change in the meantime which was also broken.
So I will merge this one on top of it

@ggerganov ggerganov merged commit be6beeb into master Sep 7, 2023
@ikawrakow ikawrakow deleted the ik/fix_kernel_norm branch September 24, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikawrakow @ggerganov @Kawrakow