Repository navigation
vulkan: handle misalignment in conv_2d and conv_3d - #29365
Merged
Merged
Conversation
github-actions
Bot
added
testing
jeffbolznv
reviewed
Sep 24, 2026
|
|
||
| std::string vars() override { | ||
| return VARS_TO_STR10(ne_input, ne_kernel, type_kernel, stride0, stride1, padding0, padding1, dilation0, dilation1, cwhn); | ||
| return VARS_TO_STR10(ne_input, ne_kernel, type_kernel, stride0, stride1, padding0, padding1, dilation0, dilation1, cwhn) + |
jeffbolznv
approved these changes
Sep 24, 2026
jeffbolznv
approved these changes
Sep 24, 2026
ggerganov
approved these changes
Sep 24, 2026
Member
|
@0cc4m Is it OK to fast-track merge this ? |
Contributor
Author
|
I had just been waiting for the CI to finish. |
1 task done
frostyautumnleaf
pushed a commit
to frostyautumnleaf/llama.cpp
that referenced
this pull request
Oct 5, 2026
* vulkan: handle misalignment in conv_2d and conv_3d * fix test-backend-ops print
edwardyoon
pushed a commit
to edwardyoon/focus-llama
that referenced
this pull request
Oct 7, 2026
* vulkan: handle misalignment in conv_2d and conv_3d * fix test-backend-ops print (cherry picked from commit 6b790a9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the Vulkan CI issues in the tests added by #29137. Also fix the same issue in CONV_2D and add tests for it.
Requirements