llama-bench : set locale to utf8 #2832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
approved these changes
Aug 27, 2023
cebtenzzre
reviewed
Aug 27, 2023
|
|
||
| int main(int argc, char ** argv) { | ||
| // try to set locale for unicode characters in markdown | ||
| setlocale(LC_CTYPE, ".UTF-8"); |
There was a problem hiding this comment.
On non-Windows platforms this is going to fail and return NULL. I think we should wrap this with #ifdef _WIN32.
There was a problem hiding this comment.
Yes, but if it fails nothing changes anyway, so I don't see the point.
There was a problem hiding this comment.
Yes, but if it fails nothing changes anyway, so I don't see the point.
I can confirm, nothing happens on Linux, locale stays what it was before the setlocale(LC_CTYPE, ".UTF-8"); call, no exceptions, no errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes garbled utf-8 characters in markdown printer under Windows 10 version 1803 and up.