cmake : remove STATIC from impl libraries, enable LLAMA_BUILD_APP by default#23462
Merged
Conversation
…ntrol Remove explicit STATIC from all -impl libraries (server, cli, completion, bench, batched-bench, fit-params, quantize, perplexity) so BUILD_SHARED_LIBS controls shared vs static linkage. Add WINDOWS_EXPORT_ALL_SYMBOLS ON for proper DLL export on Windows. Assisted-by: llama.cpp:local pi
Assisted-by: llama.cpp:local pi
ggerganov
force-pushed
the
gg/impl-shared-libs
branch
from
07bb337 to
7bd176e
Compare
ServeurpersoCom
approved these changes
May 21, 2026
angt
approved these changes
May 21, 2026
CISC
approved these changes
May 21, 2026
allozaur
approved these changes
May 21, 2026
Member
|
Not sure what went wrong here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
STATICfrom all-impllibraries (server, cli, completion, bench, batched-bench, fit-params, quantize, perplexity) soBUILD_SHARED_LIBScontrols shared vs static linkageWINDOWS_EXPORT_ALL_SYMBOLS ONfor proper DLL export on Windows when built as shared librariesLLAMA_BUILD_APPby defaultAdditional information
Addresses comment and comment from PR #23296.
Requirements