Skip to content

ui: Update KaTeX package and clean up logs from sass warnings#23275

Merged
allozaur merged 2 commits into
ggml-org:masterfrom
allozaur:allozaur/fix/katex-sass-warnings-on-build
May 18, 2026
Merged

ui: Update KaTeX package and clean up logs from sass warnings#23275
allozaur merged 2 commits into
ggml-org:masterfrom
allozaur:allozaur/fix/katex-sass-warnings-on-build

Conversation

@allozaur
Copy link
Copy Markdown
Contributor

Overview

Updates katex module where in the latest version the legacy SASS syntax issues is resolved.

Additional information

Requirements

Copilot AI review requested due to automatic review settings May 18, 2026 13:38
@allozaur allozaur requested review from a team as code owners May 18, 2026 13:38
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the KaTeX SCSS integration to use modern @use syntax (with the updated KaTeX package) to eliminate legacy @import deprecation warnings during Vite builds, and removes the now-unnecessary global SCSS preprocessor options.

Changes:

  • Replace deprecated @import with @use ... with (...) in katex-custom.scss, passing font variables directly.
  • Remove the corresponding additionalData SCSS preprocessor configuration from vite.config.ts.
  • Switch UI CI runners from ubuntu-24.04-arm to ubuntu-slim.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
tools/ui/src/styles/katex-custom.scss Migrates KaTeX SCSS import to modern @use syntax with variable overrides.
tools/ui/vite.config.ts Removes the global SCSS additionalData block since variables are now scoped via @use.
.github/workflows/ui-ci.yml Changes runner label for UI checks and E2E tests jobs.
Files not reviewed (1)
  • tools/ui/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ui-ci.yml
Comment thread .github/workflows/ui-ci.yml
@allozaur allozaur merged commit 3a9c1b8 into ggml-org:master May 18, 2026
7 of 8 checks passed
@allozaur allozaur deleted the allozaur/fix/katex-sass-warnings-on-build branch May 18, 2026 14:26
@github-actions github-actions Bot added examples devops improvements to build systems and github actions server/ui labels May 18, 2026
@CISC
Copy link
Copy Markdown
Member

CISC commented May 18, 2026

From the CI failures it looks like the slim runner does not have quite enough RAM for Node.

@allozaur
Copy link
Copy Markdown
Contributor Author

From the CI failures it looks like the slim runner does not have quite enough RAM for Node.

will switch to latest then

Jcfunk added a commit to Jcfunk/llama.cpp that referenced this pull request May 19, 2026
* master: (100 commits)
  Agent update
  hexagon: add support for TRI op (ggml-org#22822)
  ggml-hexagon: add PAD op HVX kernel (ggml-org#23078)
  docker : add OCI image labels for version and build date (ggml-org#21653)
  common : remove hf cache migration (ggml-org#23266)
  ui: Update KaTeX package and clean up logs from `sass` warnings (ggml-org#23275)
  feat: add scroll-to-bottom button to chat + prevent forced scroll down (ggml-org#23270)
  ui: Refactor models store, MCP service, and gate logs behind VITE_DEBUG (ggml-org#23236)
  ui: Centralize monospace font styles in app.css (ggml-org#23272)
  webui: fix Tailwind v4 utility classes missing when built via cmake (ggml-org#23253)
  llama: initialize pre-norm embedding mask flag (ggml-org#23256)
  add myself to conversion (ggml-org#23261)
  ci : added kleidiai-server to server-self-hosted workflow (ggml-org#22435)
  scripts : allow wc2wt with an existing branch (ggml-org#23189)
  sycl: scalar SWAR byte-subtract in Q6_K MMVQ dot product (ggml-org#22156)
  sycl: route small f32 matmuls to oneMKL, bypass oneDNN (ggml-org#22150)
  sycl : fix error when use -mg 1 error (ggml-org#23140)
  update bid to match each layers MTP source (ggml-org#23237)
  cmake : do not check for bin install dir (ggml-org#23234)
  feat: Support d_conv=15 for ssm-conv.cu (ggml-org#23017)
  ...
kgrama pushed a commit to kgrama/llama.cpp that referenced this pull request May 19, 2026
…-org#23275)

* ui: migrate katex imports to @use to resolve SCSS deprecation warnings

* ci: Use `ubuntu-slim` for CI (UI) workflow
xxmustafacooTR pushed a commit to xxPlayground/llama-cpp-turboquant that referenced this pull request May 19, 2026
…-org#23275)

* ui: migrate katex imports to @use to resolve SCSS deprecation warnings

* ci: Use `ubuntu-slim` for CI (UI) workflow
rsenthilkumar6 pushed a commit to rsenthilkumar6/llama.cpp that referenced this pull request May 19, 2026
…-org#23275)

* ui: migrate katex imports to @use to resolve SCSS deprecation warnings

* ci: Use `ubuntu-slim` for CI (UI) workflow
ArberSephirotheca pushed a commit to ArberSephirotheca/llama.cpp that referenced this pull request May 19, 2026
…-org#23275)

* ui: migrate katex imports to @use to resolve SCSS deprecation warnings

* ci: Use `ubuntu-slim` for CI (UI) workflow
fhnmor21 pushed a commit to fhnmor21/llama-cpp-turboquant that referenced this pull request May 19, 2026
…-org#23275)

* ui: migrate katex imports to @use to resolve SCSS deprecation warnings

* ci: Use `ubuntu-slim` for CI (UI) workflow
dbrain pushed a commit to dbrain/hbd-llama-cpp-turboquant that referenced this pull request May 21, 2026
…-org#23275)

* ui: migrate katex imports to @use to resolve SCSS deprecation warnings

* ci: Use `ubuntu-slim` for CI (UI) workflow
baramofme pushed a commit to baramofme/llama-cpp-turboquant that referenced this pull request May 23, 2026
…-org#23275)

* ui: migrate katex imports to @use to resolve SCSS deprecation warnings

* ci: Use `ubuntu-slim` for CI (UI) workflow
srossitto79 pushed a commit to srossitto79/llama.cpp that referenced this pull request May 23, 2026
…-org#23275)

* ui: migrate katex imports to @use to resolve SCSS deprecation warnings

* ci: Use `ubuntu-slim` for CI (UI) workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops improvements to build systems and github actions examples server/ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants