Skip to content

Conversation

@angt
Copy link
Collaborator

@angt angt commented Nov 24, 2025

Prevent forks from generating daily failure notifications.

Prevent forks from generating daily failure notifications.

Signed-off-by: Adrien Gallouët <angt@huggingface.co>
@angt angt requested a review from slaren as a code owner November 24, 2025 08:56
update:
name: Update Winget Package
runs-on: ubuntu-latest
if: ${{ github.repository.owner.login == 'ggml-org' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could check if secrets.WINGET_GITHUB_TOKEN exists instead.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just found my last comment disappeared (I did something wrong with github I guess..) so let me resume my last comment:

Checking secrets.WINGET_GITHUB_TOKEN would not fix my issue as the build will fail before for various reasons (no release, no tags, etc).

But also this step has no value outside of ggml-org and explicitly use it:

--urls "https://github.com/ggml-org/llama.cpp/releases/download/${{ env.VERSION }}/llama-${{ env.VERSION }}-bin-win-vulkan-x64.zip" \

In the scenario where the action is performed under ggml-org, I believe a red notification would be beneficial if the secret is missing.

@github-actions github-actions bot added the devops improvements to build systems and github actions label Nov 24, 2025
@angt
Copy link
Collaborator Author

angt commented Dec 2, 2025

Every morning I have a reminder of this PR :)

Screenshot 2025-12-02 at 09 54 19

@taronaeo
Copy link
Collaborator

taronaeo commented Dec 2, 2025

Looks like @/slaren is on hiatus as stated here: #17639 (comment)

Pinging @CISC for a review instead :)

@taronaeo taronaeo requested a review from CISC December 2, 2025 09:00
@CISC CISC merged commit 4574f29 into ggml-org:master Dec 2, 2025
2 of 3 checks passed
@wqerrewetw
Copy link

.github/workflows/docker.yml also need this

@CISC
Copy link
Collaborator

CISC commented Dec 2, 2025

.github/workflows/docker.yml also need this

Why? Docker builds work on forks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops improvements to build systems and github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants