-
Notifications
You must be signed in to change notification settings - Fork 13.9k
ci : skip winget update when not in ggml-org #17465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci : skip winget update when not in ggml-org #17465
Conversation
Prevent forks from generating daily failure notifications. Signed-off-by: Adrien Gallouët <angt@huggingface.co>
| update: | ||
| name: Update Winget Package | ||
| runs-on: ubuntu-latest | ||
| if: ${{ github.repository.owner.login == 'ggml-org' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could check if secrets.WINGET_GITHUB_TOKEN exists instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just found my last comment disappeared (I did something wrong with github I guess..) so let me resume my last comment:
Checking secrets.WINGET_GITHUB_TOKEN would not fix my issue as the build will fail before for various reasons (no release, no tags, etc).
But also this step has no value outside of ggml-org and explicitly use it:
llama.cpp/.github/workflows/winget.yml
Line 39 in 6ab4e50
| --urls "https://github.com/ggml-org/llama.cpp/releases/download/${{ env.VERSION }}/llama-${{ env.VERSION }}-bin-win-vulkan-x64.zip" \ |
In the scenario where the action is performed under ggml-org, I believe a red notification would be beneficial if the secret is missing.
|
Looks like @/slaren is on hiatus as stated here: #17639 (comment) Pinging @CISC for a review instead :) |
|
|
Why? Docker builds work on forks. |

Prevent forks from generating daily failure notifications.