Skip to content

SYCL: add full support for ABS unary op #17126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

SYCL: add full support for ABS unary op #17126

wants to merge 6 commits into from

Conversation

@shani-f
Copy link
Contributor

@shani-f shani-f commented Nov 9, 2025

This PR adds full SYCL backend support for GGML_UNARY_OP_ABS.

What’s included

  • Implemented ABS kernel with correct handling of tensor strides (nb, nbd)
  • Supports both f16 and f32
  • Works for contiguous and non-contiguous (view) tensors
  • Added ABS to the SYCL unary dispatch logic
  • All tests in test-backend-ops pass (f16/f32, view & non-view)

Notes

  • No changes for CPU or CUDA paths
  • No impact on performance of other unary ops

@github-actions github-actions bot added ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language labels Nov 9, 2025
@DajanaV DajanaV mentioned this pull request Nov 9, 2025
Open
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shani-f