-
Notifications
You must be signed in to change notification settings - Fork 13.5k
SYCL: Add COUNT_EQUAL operator support #15991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- could you rebase the code since sycl_parallel_for() is reverted to stream->parallel_for() in base?
- same commit of #15937.
Thank you!
d401537 to
337d9f8
Compare
3031181 to
b39cc2d
Compare
ggml/src/ggml-sycl/binbcast.hpp
Outdated
|
|
||
| return a - b; | ||
|
|
||
| static __dpct_inline__ float op_count_equal(const float a, const float b) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove duplicated code in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review!
I removed the duplicated op_count_equal definition from binbcast.hpp as requested.
The branch is now rebased on the latest master and clean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for great work!
3b29473 to
163b949
Compare
d3b3536 to
0f6b7fd
Compare
0f6b7fd to
b427efb
Compare
|
The iOS CI job is failing due to a missing SDK on the runner (iOS 26.0 is not installed), which seems unrelated to this PR. |
Summary
This PR adds GGML_OP_COUNT_EQUAL support to the SYCL backend.
Changes
ggml_sycl_op_count_equal()and its wrapperggml_sycl_count_equal()GGML_OP_COUNT_EQUALin:ggml_sycl_compute_forward()ggml_backend_sycl_device_supports_op()docs/ops.mdand regenerateddocs/ops/SYCL.csvto reflect SYCL supportF32,F16,I32, andI16Verification
cmake+make