-
Couldn't load subscription status.
- Fork 13.4k
model : avoid ggml_cont_3d for fused QKV weights #15662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f15d515 to
3dec397
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with CodeQwen1.5, Phi2, jina-embeddings-v3 and PLaMo2.
Ah, I get a segfault locally though at the first |
|
On my end, all tests except |
Nvm, must have been some other issue pre-rebase, I pulled latest changes and applied #15868 and everything is fine now. Edit: Eh, almost, got |
)" This reverts commit cf0e3ba.
ref #15602 (comment)
Vcur = ggml_cont_3d(..)when the QKV weights are merged in a single tensorllama_kv_cache::cpy_kandcpy_vmore readable