vulkan: Add missing bounds checking to scalar/coopmat1 mul_mat_id #15334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
jeffbolznv
commented
Aug 14, 2025
| #else | ||
| const uint row_i = ic * BN + loadc_b + l; | ||
| if (row_i < _ne1) { | ||
| if (row_i < _ne1 && block + loadr_b < end_k) { |
There was a problem hiding this comment.
@0cc4m I couldn't reproduce a failure without this check, but it seems like it should be necessary. Am I missing something?
There was a problem hiding this comment.
Not sure. It does seem like it should be there, yeah.
This was referenced Aug 14, 2025
0cc4m
approved these changes
Aug 16, 2025
| #else | ||
| const uint row_i = ic * BN + loadc_b + l; | ||
| if (row_i < _ne1) { | ||
| if (row_i < _ne1 && block + loadr_b < end_k) { |
There was a problem hiding this comment.
Not sure. It does seem like it should be there, yeah.
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #15274.