-
Notifications
You must be signed in to change notification settings - Fork 12.1k
release : fix windows hip release #13707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Its not necessary, no. you can have fat binaries. Im not sure how useful the windows builds are atm really since the list of targets is so small and rather random. The only really feasible way to support windows rocm is to have people self build. |
Thanks for the insight. I wonder how other projects handle this. @YellowRoseCx I believe you distribute koboldcpp packages for rocm, can you share some insights of how you handle the different GPU targets in a single release? |
koboldcpp is built for gfx803, gfx900, gfx906, gfx908, gfx90a, gfx1010, gfx1030, gfx1031, gfx1032, gfx1100, gfx1101 and gfx1102 amd is currenly in the process of introducing generics ie gfx9-generic gfx10.3-generic, gfx11-generic and gfx12-generic that will make this mutch better as then we will only have to build those + gfx1100 and + gfx906, gfx908, gfx90a and gfx942 on linux. They are also in the process of introducing a amdgcn-spirv target to llvm that will allow similar functionality as building the cuda version for ptx |
Alright, thanks. I am going to give it a try to include all of these targets in a single binary. The rocblas libraries that are included in our HIP releases are already 900MB, so I figure that even if the size of |
Adding all of these targets didn't work very well, so instead I added the supported radeon targets listed in the documentation. This results in a 210MB |
Fixes #13698