-
Notifications
You must be signed in to change notification settings - Fork 11.9k
sycl: add find_package call for OpenCL #13643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Romain Biessy <romain.biessy@codeplay.com>
Shouldn't the |
This is used when building oneDNN not when building llama, |
I think Svet makes a good point. This could be fixed in the generated oneDNN config file similarly to this PR: uxlfoundation/oneDNN#2768 |
This PR could resolve your issue during building oneDNN. This PR should be updated to oneDNN build script, instead of llama.cpp. |
The nightly dpcpp compiler recently stopped shipping libOpenCL.so.
So when one uses a nightly build of oneDNN built with the said nightly compiler, it links against the target
OpenCL::OpenCL
(see this line), and when using this build of oneDNN in llama, it would expect the targetOpenCL::OpenCL
to be available.This PR simply adds the
find_package(OpenCL)
when using the nightly compiler to resolve the same.