-
Notifications
You must be signed in to change notification settings - Fork 11.9k
sycl: Add more debug prints #13640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
sycl: Add more debug prints #13640
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
Is it possible to extend this to backend interface functions as well such as init, set, memset, clear, reset, etc?
I added some more logs and updated the example in the PR description. Note I am not reusing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If logs get too noisy we can implement a couple of levels to the debug variable in the future to either print ops or API calls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I switched from using |
This adds more debugging prints related to the operations being run.
scope_op_debug_print
is introduced to print the "call ..." and "call ... done" logs in a single line.This adds more information for all the operations and its destination and input tensors: the tensor type, its number of elements, stride sizes and whether the tensor is strided (i.e. non-contiguous) or permuted.
For mul_mat this also add some debug prints when conversations kernels are called from and to fp16, fp32 and quantized types.
This also adds debugging prints for a few operations that were missing it.
The output for llama-2-7b.Q4_0 PP and TG is added here as an example: