Skip to content

ci: fix cross-compile sync issues #12804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
May 1, 2025

Conversation

bandoti
Copy link
Collaborator

@bandoti bandoti commented Apr 7, 2025

During the Linux cross-compile CI setup there seem to be issues syncing dependencies, causing unnecessary build failures and delays in CI success. This PR is an attempt to address that issue.

@github-actions github-actions bot added the devops improvements to build systems and github actions label Apr 7, 2025
@bandoti bandoti added build Compilation issues and removed build Compilation issues labels Apr 7, 2025
@bandoti bandoti self-assigned this Apr 7, 2025
@bandoti bandoti requested a review from slaren April 7, 2025 19:13
@bandoti
Copy link
Collaborator Author

bandoti commented Apr 19, 2025

@slaren I am going to submit a separate PR tomorrow to (for now) remove the cross-compiling from the CI. I don't currently have time to get this one working, so that will be a workaround.

@bandoti
Copy link
Collaborator Author

bandoti commented May 1, 2025

@slaren It looks like the solution was hiding in plain sight! The apt-get update was only failing when bad repository URLs appeared at the end of the output, which is why failures were somewhat random. So, I think it's good to go now after suppressing those failures.

One thing I changed is how the ports repositories are added. Instead of mangling the default azure repositories (which only applies to Github runners), I opted to create a more realistic cross-compile example by directly adding the Ubuntu ports repos alongside the existing ones. This way folks could perform the same steps on a local Ubuntu system without issue.

Copy link
Member

@slaren slaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Minor nit, the fetch-depth: 0 in the checkout actions shouldn't be necessary here, that's only used in the releases so that the build number can be calculated correctly.

@bandoti
Copy link
Collaborator Author

bandoti commented May 1, 2025

Fixed the fetch depth will merge once build finishes. 😊

@bandoti bandoti merged commit d24d592 into ggml-org:master May 1, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops improvements to build systems and github actions examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants