Skip to content

minor: web-ui typo fixes #12116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 1, 2025
Merged

minor: web-ui typo fixes #12116

merged 4 commits into from
Mar 1, 2025

Conversation

vynride
Copy link
Contributor

@vynride vynride commented Feb 28, 2025

  • Fixed typos in web-ui
  • Renamed the variable 'trimedValue' to 'trimmedValue'
  • Clarified the confirmation box text

@ngxson ngxson merged commit 2cc4a5e into ggml-org:master Mar 1, 2025
6 checks passed
@vynride
Copy link
Contributor Author

vynride commented Mar 1, 2025

@ngxson Any insight into why the checks kept failing?

$ node --version
v23.9.0

I ran the build on an updated EndeavourOS installation.

mglambda pushed a commit to mglambda/llama.cpp that referenced this pull request Mar 8, 2025
* fix typos and improve menu text clarity

* rename variable trimedValue to trimmedValue

* add updated index.html.gz

* rebuild

---------

Co-authored-by: Xuan Son Nguyen <son@huggingface.co>
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Mar 19, 2025
* fix typos and improve menu text clarity

* rename variable trimedValue to trimmedValue

* add updated index.html.gz

* rebuild

---------

Co-authored-by: Xuan Son Nguyen <son@huggingface.co>
@ericcurtin
Copy link
Collaborator

Why not store examples/server/public/index.html.gz uncompressed in version control :)

@ngxson
Copy link
Collaborator

ngxson commented Mar 24, 2025

@ericcurtin If you know how to generate the compressed version at build time, please open a PR.

mostlyuseful pushed a commit to mostlyuseful/llama.cpp that referenced this pull request May 12, 2025
* fix typos and improve menu text clarity

* rename variable trimedValue to trimmedValue

* add updated index.html.gz

* rebuild

---------

Co-authored-by: Xuan Son Nguyen <son@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants