Vulkan: Add device-specific blacklist for coopmat for the AMD proprietary driver #11074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Vulkan
jeffbolznv
reviewed
Jan 4, 2025
ggml/src/ggml-vulkan/ggml-vulkan.cpp
Outdated
| if (driver_props.driverID == vk::DriverId::eAmdProprietary || driver_props.driverID == vk::DriverId::eAmdOpenSource) { | ||
| // Workaround for AMD proprietary driver reporting support on all GPUs | ||
| const std::string name = props.deviceName; | ||
| return name.rfind("AMD Radeon RX 7", 0) == 0 || // RDNA 3 consumer GPUs |
There was a problem hiding this comment.
Is there a way to write this so newer GPUs will be enabled by default?
There was a problem hiding this comment.
That would be good, but I couldn't think of an easy way. I'm hoping that AMD resolves this in their drivers, then we can just remove the check.
I'll try to figure out the proper way to report this to their Windows and amdvlk driver team.
jeffbolznv
approved these changes
Jan 4, 2025
|
I noticed that AMD sometimes adds |
tinglou
pushed a commit
to tinglou/llama.cpp
that referenced
this pull request
Feb 13, 2025
…tary driver (ggml-org#11074) * Vulkan: Add device-specific blacklist for coopmat for the AMD proprietary driver * Add (TM) to AMD name check
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Feb 26, 2025
…tary driver (ggml-org#11074) * Vulkan: Add device-specific blacklist for coopmat for the AMD proprietary driver * Add (TM) to AMD name check
mglambda
pushed a commit
to mglambda/llama.cpp
that referenced
this pull request
Mar 8, 2025
…tary driver (ggml-org#11074) * Vulkan: Add device-specific blacklist for coopmat for the AMD proprietary driver * Add (TM) to AMD name check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a workaround for AMD's proprietary Vulkan driver and amdvlk reporting support for cooperative matrix on GPUs without the necessary hardware. Since Vulkan has no concept of compute capability (to my knowledge), I used the device name. Let me know if you see an issue with that.
Please test this with AMD GPUs, especially with Windows or amdvlk, to ensure it works as intended.