Skip to content

CI: Move msvc to matrix #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2025
Merged

CI: Move msvc to matrix #1318

merged 1 commit into from
Aug 2, 2025

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jul 29, 2025

Enable static builds and testing.

... except that the test results must be ignored for Windows: test-timestep_embedding is flaky. The actual result doesn't always match the expected result. Example:

 6/19 Test  #6: test-arange ......................   Passed    0.01 sec
test 7
      Start  7: test-timestep_embedding

7: Test command: D:\a\ggml\ggml\build\bin\Release\test-timestep_embedding.exe
7: Working Directory: D:/a/ggml/ggml/build/tests
7: Environment variables: 
7:  LLVM_PROFILE_FILE=test-timestep_embedding.profraw
7: Test timeout computed to be: 900
7: 0.8439 -0.9970 0.6497 0.9733 0.9981 0.9999 1.0000 -0.5366 -0.0776 0.7602 0.2296 0.0621 0.0167 0.0045 0.0000 0.0000 0.4242 0.9880 -0.1558 0.8946 0.9923 0.9994 1.0000 -0.9056 0.1547 0.9878 0.4470 0.1240 0.0333 0.0089 0.0000 0.0000 
7: -----------------------------------
7: 0.8439 -0.9970 0.6497 0.9733 0.9981 0.9999 1.0000 -0.5366 -0.0776 0.7602 0.2296 0.0621 0.0167 0.0045 242.7236 D:\a\ggml\ggml\tests\test-timestep_embedding.cpp:171: GGML_ASSERT(equalsf(output[i], expected_result[i])) failed
 7/19 Test  #7: test-timestep_embedding ..........Exit code 0xc0000409
***Exception:   0.29 sec

Cf. "Msvc" runs in https://github.com/dg0yt/ggml/actions/workflows/ci.yml.
All errors occured for expected value 0.
Tests didn't run for MSVC before this PR, so the test failure isn't a regression.

I didn't check if there is another way to exclude the flaky test.

Copy link
Member

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can re-enable the failing windows tests so that we have a motivation to fix them. Otherwise we will definitely forget about this.

Enable static builds and testing
@dg0yt
Copy link
Contributor Author

dg0yt commented Jul 31, 2025

This CI run passed, but the parallel test in dg0yt#3 failed again. Flaky. This will affect other people's PRs here.

@ggerganov ggerganov merged commit 4af7c56 into ggml-org:master Aug 2, 2025
8 checks passed
@dg0yt dg0yt deleted the msvc branch August 2, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants