Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go bindings updated so they can be used in third party packages. #379

Merged
merged 2 commits into from
Jan 6, 2023
Merged

go bindings updated so they can be used in third party packages. #379

merged 2 commits into from
Jan 6, 2023

Conversation

djthorpe
Copy link
Contributor

@djthorpe djthorpe commented Jan 6, 2023 •
edited
Loading

  • go.sum should be included in the repository go : go.sum should be included in git #362
  • Removed LDFLAGS and CFLAGS so that bindings can be used in third party packages
  • Added some more README documentation
  • Simplified go-model-download slightly
  • Added Whisper_n_audio_ctx binding

@djthorpe djthorpe mentioned this pull request Jan 6, 2023
Closed
@djthorpe
Copy link
Contributor Author

djthorpe commented Jan 6, 2023

Three other changes, which you can edit as needed:

  • In the main Makefile, for Darwin target, checks for processor FMA instructions before adding -mfma compiler flag. My Xeon processor (MacPro 2013) does not have this
  • Updated the minimum CMake version to 3.18 - this is the default version for Debian bullseye, which is the latest Debian
  • CMakeLists.txt added WHISPER_NO_FMA option for Darwin for my very old Mac Pro

@ggerganov ggerganov merged commit 322f4e6 into ggerganov:master Jan 6, 2023
rock3125 pushed a commit to rock3125/whisper.cpp that referenced this pull request Feb 21, 2023
@djthorpe @rock3125
go : bindings updated so they can be used in third party packages. (g…
16cabfe 
…gerganov#379)

* Updated bindings so they can be used in third pary packages.

* Updated makefiles to set FMA flag on optionally, for xeon E5 on Darwin
anandijain pushed a commit to anandijain/whisper.cpp that referenced this pull request Apr 28, 2023
@djthorpe
go : bindings updated so they can be used in third party packages. (g…
47a3c89 
…gerganov#379)

* Updated bindings so they can be used in third pary packages.

* Updated makefiles to set FMA flag on optionally, for xeon E5 on Darwin
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
@djthorpe
go : bindings updated so they can be used in third party packages. (g…
c7eef6d 
…gerganov#379)

* Updated bindings so they can be used in third pary packages.

* Updated makefiles to set FMA flag on optionally, for xeon E5 on Darwin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djthorpe @ggerganov