-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore big endian support #2816
Restore big endian support #2816
Conversation
It looks like the
This seems unrelated to the change in this pull request. I cannot find a way to restart the failed checks though. |
The easiest way to restart the CI runs is to do fetch the latest master from ggerganov, followed by 'git rebase ggerganov/master' and 'git push -f fitzsim restore-big-endian-support' assuming your remote git repo is 'fitzsim'. |
Makes sense, thanks, however I will have to wait until a new commit lands on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix the CI, we can apply the same fix that we did in llama.cpp: ggml-org/llama.cpp#11895
* docker : attempt fixing arm64 build on ci * qemu v7.0.0-28 [imported from https://github.com/ggml-org/llama.cpp /commit/818a340ea8be55b3706e1772527cb8738e90a8c7 (#11895)]
1de3d1a
to
896b32f
Compare
Restore big endian support, which worked with the
Makefile
, toCMake
, eliminateC++23
reliance, fix some whitespace. It might make sense to move this logic intoggml
at some point.