Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore big endian support #2816

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

fitzsim
Copy link
Contributor

@fitzsim fitzsim commented Feb 14, 2025

Restore big endian support, which worked with the Makefile, to CMake, eliminate C++23 reliance, fix some whitespace. It might make sense to move this logic into ggml at some point.

@fitzsim
Copy link
Contributor Author

fitzsim commented Feb 15, 2025

It looks like the linux/arm64 continuous integration machine had a system issue:

Processing triggers for libc-bin (2.35-0ubuntu3.8) ...
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
Segmentation fault (core dumped)
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
Segmentation fault (core dumped)
dpkg: error processing package libc-bin (--configure):
 installed libc-bin package post-installation script subprocess returned error exit status 139
Processing triggers for ca-certificates (20240203~22.04.1) ...
Updating certificates in /etc/ssl/certs...
0 added, 0 removed; done.
Running hooks in /etc/ca-certificates/update.d...
done.
Errors were encountered while processing:
 libc-bin
E: Sub-process /usr/bin/dpkg returned an error code (1)

This seems unrelated to the change in this pull request. I cannot find a way to restart the failed checks though.

@petterreinholdtsen
Copy link
Contributor

The easiest way to restart the CI runs is to do fetch the latest master from ggerganov, followed by 'git rebase ggerganov/master' and 'git push -f fitzsim restore-big-endian-support' assuming your remote git repo is 'fitzsim'.

@fitzsim
Copy link
Contributor Author

fitzsim commented Feb 18, 2025

The easiest way to restart the CI runs is to do fetch the latest master from ggerganov, followed by 'git rebase ggerganov/master' and 'git push -f fitzsim restore-big-endian-support' assuming your remote git repo is 'fitzsim'.

Makes sense, thanks, however I will have to wait until a new commit lands on master.

Copy link
Owner

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the CI, we can apply the same fix that we did in llama.cpp: ggml-org/llama.cpp#11895

fitzsim and others added 2 commits February 22, 2025 16:52
* docker : attempt fixing arm64 build on ci

* qemu v7.0.0-28

[imported from
https://github.com/ggml-org/llama.cpp
/commit/818a340ea8be55b3706e1772527cb8738e90a8c7
(#11895)]
@ggerganov ggerganov merged commit 47e14c0 into ggerganov:master Feb 25, 2025
39 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants