New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sampling : fix off-by-one in tail-free sampling #9604

Open

ggerganov wants to merge 1 commit into master from gg/tfs-ob1

+9 −7

Owner

ggerganov commented Sep 23, 2024

The tail-free sampler was incorrectly using the index to set the size of the candidates resulting in the size being 1 less than it has to be.

I have read the contributing guidelines
Self-reported review complexity:
- Low
- Medium
- High


          sampling : fix off-by-one in tail-free sampling

114ab63

ggml-ci

github-actions bot added the testing label

ggerganov mentioned this pull request

keep the minimum min_keep value to 1 in sampling #9603

Open

4 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing