metal : use F32 prec for K*Q in vec FA #9595
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that Qwen2-7B-Instruct with Metal FA produces garbage:
./llama-cli -m ./models/qwen2-7b-instruct/ggml-model-f16.gguf -p "I believe the meaning of life is" -n 16 -s 1 --temp 0.0 -fa
master
PR
Seems to be again insufficient precision in the K*Q multiplication, this time only in the vec FA kernel (it works OK with the non-vec kernel). Should make K*Q always use F32 precision - proves to be very sensitive operation.