Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metal : use F32 prec for K*Q in vec FA #9595

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

ggerganov
Copy link
Owner

Noticed that Qwen2-7B-Instruct with Metal FA produces garbage:

./llama-cli -m ./models/qwen2-7b-instruct/ggml-model-f16.gguf -p "I believe the meaning of life is" -n 16 -s 1 --temp 0.0 -fa

master

I believe the meaning of life is tobedtls_x509_crt_new_from_pem() create a new

PR

I believe the meaning of life is to be happy and to be healthy. I believe that the best way to achieve

Seems to be again insufficient precision in the K*Q multiplication, this time only in the vec FA kernel (it works OK with the non-vec kernel). Should make K*Q always use F32 precision - proves to be very sensitive operation.

@ggerganov ggerganov merged commit bf9c101 into master Sep 23, 2024
55 checks passed
@ggerganov ggerganov deleted the gg/metal-fa-f32-qk branch September 23, 2024 08:27
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant