Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server : clean-up completed tasks from waiting list #9531

Merged
merged 1 commit into from
Sep 19, 2024
Merged

server : clean-up completed tasks from waiting list #9531

merged 1 commit into from
Sep 19, 2024

Conversation

ggerganov
Copy link
Owner

fix #9528

Restore missing remove_waiting_...() calls after tasks have completed.

@ggerganov ggerganov mentioned this pull request Sep 18, 2024
Closed
ngxson
ngxson approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@ngxson ngxson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ggerganov ggerganov merged commit 6026da5 into master Sep 19, 2024
57 of 58 checks passed
@ggerganov ggerganov deleted the gg/server-remove-waiting branch September 19, 2024 09:44
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
@ggerganov @dsx1986
server : clean-up completed tasks from waiting list (ggerganov#9531)
29a8040 
ggml-ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngxson ngxson ngxson approved these changes

Assignees
No one assigned
Labels
examples server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: task ids not removed from waiting_tasks for /v1/chat/completions call
2 participants
@ggerganov @ngxson