Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server : test script : add timeout for all requests #9282

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

ngxson
Copy link
Collaborator

@ngxson ngxson commented Sep 2, 2024

Some steps in server test script are missing timeout config, which make it to use the default value of 300 seconds

This causes the the CI to randomly (and rarely) fail. Mostly due to the instability of hosted runner:

This PR add timeout everywhere in the script, the value is 600 seconds, which is double the default value.


@github-actions github-actions bot added examples python python script changes server labels Sep 2, 2024
@ngxson
Copy link
Collaborator Author

ngxson commented Sep 2, 2024

Small note: I tested the stability of CI by re-running test multiple times (mixed between slow and default test configs).

In rare occasion, windows test failed due to ERROR: Server stopped listening. After more careful inspections, I believe that the problem comes from race condition inside the test script itself. Since it rarely happens and is windows-only, I won't go deeper right now (i.e. won't fix)

@ngxson ngxson merged commit 48baa61 into ggerganov:master Sep 2, 2024
12 checks passed
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples python python script changes server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants