common : Changed tuple to struct (TODO fix) #8823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use struct `llama_init_result` to replace the previous std::tuple<struct llama_model *, struct llama_context *>
6 tasks
ngxson
requested changes
Aug 4, 2024
|
I have modified the code according to your suggestion. |
ggerganov
approved these changes
Aug 5, 2024
ngxson
approved these changes
Aug 5, 2024
|
Found CI failed. I have submitted a new commit to delete the extra whitespace in this PR. |
mofosyne
added
the
Review Complexity : Low
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Aug 7, 2024
* common : Changed tuple to struct (TODO fix) Use struct `llama_init_result` to replace the previous std::tuple<struct llama_model *, struct llama_context *> * delete llama_init_default_params() * delete the extra whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use struct
llama_init_resultto replace the previousstd::tuple<struct llama_model *, struct llama_context *>