Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPM infill support #8016

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Add SPM infill support #8016

merged 4 commits into from
Jun 28, 2024

Conversation

CISC
Copy link
Contributor

@CISC CISC commented Jun 19, 2024

Add SPM infill (Suffix(Prefix/Middle pattern) support for models like Codestral that require this.

@mofosyne mofosyne added the Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix label Jun 19, 2024
@CISC
Copy link
Contributor Author

CISC commented Jun 26, 2024

@slaren Mind reviewing this one?

Copy link
Collaborator

@slaren slaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not very familiar with this feature, but the code looks good to me.

@slaren slaren merged commit 38373cf into ggerganov:master Jun 28, 2024
52 of 53 checks passed
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jun 30, 2024
* add --spm-infill option

* support --spm-infill

* support --spm-infill
Nexesenex pushed a commit to Nexesenex/croco.cpp that referenced this pull request Jun 30, 2024
* add --spm-infill option

* support --spm-infill

* support --spm-infill
MagnusS0 pushed a commit to MagnusS0/llama.cpp-normistral-tokenizer that referenced this pull request Jul 1, 2024
* add --spm-infill option

* support --spm-infill

* support --spm-infill
Nexesenex pushed a commit to Nexesenex/croco.cpp that referenced this pull request Jul 1, 2024
* add --spm-infill option

* support --spm-infill

* support --spm-infill
@CISC CISC deleted the spm-infill-support branch August 6, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants