[SYCL] Update rpc-server.cpp to include SYCL backend #7682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft PR to address inclusion of SYCL backend for RPC server
nickp27
changed the title
rgerganov
reviewed
Jun 2, 2024
| @@ -81,6 +85,14 @@ static ggml_backend_t create_backend() { | |||
| } | |||
| #endif | |||
|
|
|||
| #elif GGML_USE_SYCL | |||
There was a problem hiding this comment.
this will give a compile error if you don't remove the #endif on line 86
There was a problem hiding this comment.
Should be resolved now!
rgerganov
approved these changes
Jun 2, 2024
|
Does this really work? The SYCL backend has extras that are initialized during |
|
It's currently failing - see #7718, although I suspect that issue is only one of a number possibly, having spent a few hours trying to get it working and seeing that similar issues have persisted with whisper.cpp for the last couple of months |
slaren
added a commit
that referenced
this pull request
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to address inclusion of SYCL backend for RPC server