Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] fix intel docker #7630

Merged
merged 4 commits into from
May 30, 2024
Merged

[SYCL] fix intel docker #7630

merged 4 commits into from
May 30, 2024

Conversation

airMeng
Copy link
Collaborator

@airMeng airMeng commented May 30, 2024

@airMeng airMeng requested a review from mofosyne May 30, 2024 02:55
@github-actions github-actions bot added the devops improvements to build systems and github actions label May 30, 2024
@airMeng airMeng requested a review from ngxson May 30, 2024 02:58
@mofosyne mofosyne mentioned this pull request May 30, 2024
Closed
@mofosyne
Copy link
Collaborator

mofosyne commented May 30, 2024 •
edited
Loading

@airMeng there was some docker error regarding the existence of libcurl4-openssl-dev

I don't think it's an intel package, what do you think is happening here? At least I'm not seeing a gpg error.

@airMeng
Copy link
Collaborator Author

airMeng commented May 30, 2024

@mofosyne fixed, could you give a review?

@mofosyne mofosyne added Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix merge ready indicates that this may be ready to merge soon and is just holding out in case of objections labels May 30, 2024
@mofosyne
Copy link
Collaborator

LGTM

@mofosyne mofosyne merged commit 3854c9d into master May 30, 2024
21 checks passed
@airMeng airMeng deleted the Fix-intel-docker branch May 30, 2024 06:24
airMeng added a commit that referenced this pull request Jun 12, 2024
@airMeng
Revert "[SYCL] fix intel docker (#7630)"
c21d603 
This reverts commit 3854c9d.
@airMeng airMeng mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mofosyne mofosyne mofosyne approved these changes

@ngxson ngxson Awaiting requested review from ngxson

Assignees
No one assigned
Labels
devops improvements to build systems and github actions merge ready indicates that this may be ready to merge soon and is just holding out in case of objections Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@airMeng @mofosyne