Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing option in visual studio. #7574

Merged
merged 1 commit into from
May 27, 2024

Conversation

kunnis
Copy link
Contributor

@kunnis kunnis commented May 27, 2024

debug, release and static are hidden, making them not selectable in Visual Studio, so you can't (easily) compile for X86_64 on windows. Currently they are not visible in the UI, but accessible via command line. This makes them visible in the UI.

@github-actions github-actions bot added the build Compilation issues label May 27, 2024
@slaren
Copy link
Collaborator

slaren commented May 27, 2024

I suspect these presets are meant to be used only as the base of other presets. Might be better to create new presets that inherits from these, like there are for arm.

@kunnis kunnis force-pushed the WindowsCmakePresets branch from e820eeb to db0aba2 Compare May 27, 2024 21:27
@kunnis
Copy link
Contributor Author

kunnis commented May 27, 2024

@slaren That makes sense. I doubt I have the targets fully defined, but at least they exist now, and I can compile.

@slaren slaren merged commit 0136966 into ggerganov:master May 27, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Compilation issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants