Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUDA: fix unused warning in mmq.cu #7442

Merged
merged 1 commit into from
May 21, 2024

Conversation

JohannesGaessler
Copy link
Collaborator

Fixup to #7397 .

Adds GGML_UNUSED to suppress a warning when compiling for compute capabilities < 6.1.

@mofosyne mofosyne added Nvidia GPU Issues specific to Nvidia GPUs Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix merge ready indicates that this may be ready to merge soon and is just holding out in case of objections labels May 21, 2024
Copy link
Contributor

📈 llama.cpp server for bench-server-baseline on Standard_NC4as_T4_v3 for phi-2-q4_0: 510 iterations 🚀

Expand details for performance related PR only
  • Concurrent users: 8, duration: 10m
  • HTTP request : avg=9190.26ms p(95)=21777.73ms fails=, finish reason: stop=456 truncated=54
  • Prompt processing (pp): avg=108.24tk/s p(95)=478.94tk/s
  • Token generation (tg): avg=35.64tk/s p(95)=46.17tk/s
  • ggml-org/models/phi-2/ggml-model-q4_0.gguf parallel=8 ctx-size=16384 ngl=33 batch-size=2048 ubatch-size=256 pp=1024 pp+tg=2048 branch=cuda-fix-mmq-warning commit=219f39b068293c958b242294ca17525298f35da3

prompt_tokens_seconds

More
---
config:
    xyChart:
        titleFontSize: 12
        width: 900
        height: 600
    themeVariables:
        xyChart:
            titleColor: "#000000"
---
xychart-beta
    title "llama.cpp bench-server-baseline on Standard_NC4as_T4_v3
 duration=10m 510 iterations"
    y-axis "llamacpp:prompt_tokens_seconds"
    x-axis "llamacpp:prompt_tokens_seconds" 1716311606 --> 1716312234
    line [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 275.39, 275.39, 275.39, 275.39, 275.39, 806.77, 806.77, 806.77, 806.77, 806.77, 848.16, 848.16, 848.16, 848.16, 848.16, 854.87, 854.87, 854.87, 854.87, 854.87, 895.9, 895.9, 895.9, 895.9, 895.9, 904.59, 904.59, 904.59, 904.59, 904.59, 909.69, 909.69, 909.69, 909.69, 909.69, 924.36, 924.36, 924.36, 924.36, 924.36, 926.29, 926.29, 926.29, 926.29, 926.29, 921.43, 921.43, 921.43, 921.43, 921.43, 942.15, 942.15, 942.15, 942.15, 942.15, 942.26, 942.26, 942.26, 942.26, 942.26, 854.58, 854.58, 854.58, 854.58, 854.58, 770.76, 770.76, 770.76, 770.76, 770.76, 767.33, 767.33, 767.33, 767.33, 767.33, 774.9, 774.9, 774.9, 774.9, 774.9, 784.39, 784.39, 784.39, 784.39, 784.39, 783.59, 783.59, 783.59, 783.59, 783.59, 800.36, 800.36, 800.36, 800.36, 800.36, 804.17, 804.17, 804.17, 804.17, 804.17, 806.9, 806.9, 806.9, 806.9, 806.9, 813.69, 813.69, 813.69, 813.69, 813.69, 810.52, 810.52, 810.52, 810.52, 810.52, 811.9, 811.9, 811.9, 811.9, 811.9, 753.31, 753.31, 753.31, 753.31, 753.31, 754.46, 754.46, 754.46, 754.46, 754.46, 756.65, 756.65, 756.65, 756.65, 756.65, 773.11, 773.11, 773.11, 773.11, 773.11, 774.11, 774.11, 774.11, 774.11, 774.11, 769.39, 769.39, 769.39, 769.39, 769.39, 770.73, 770.73, 770.73, 770.73, 770.73, 775.41, 775.41, 775.41, 775.41, 775.41, 776.65, 776.65, 776.65, 776.65, 776.65, 775.45, 775.45, 775.45, 775.45, 775.45, 780.83, 780.83, 780.83, 780.83, 780.83, 770.23, 770.23, 770.23, 770.23, 770.23, 752.61, 752.61, 752.61, 752.61, 752.61, 756.21, 756.21, 756.21, 756.21, 756.21, 757.82, 757.82, 757.82, 757.82, 757.82, 755.56, 755.56, 755.56, 755.56, 755.56, 755.88, 755.88, 755.88, 755.88, 755.88, 759.52, 759.52, 759.52, 759.52, 759.52, 763.79, 763.79, 763.79, 763.79, 763.79, 763.79, 763.79, 763.79, 763.79, 763.79, 748.72, 748.72, 748.72, 748.72, 748.72, 756.63, 756.63, 756.63, 756.63, 756.63, 757.51, 757.51, 757.51, 757.51, 757.51, 757.15, 757.15, 757.15, 757.15, 757.15, 756.02, 756.02, 756.02, 756.02, 756.02, 760.87, 760.87, 760.87, 760.87, 760.87, 764.26, 764.26, 764.26, 764.26, 764.26, 764.11, 764.11, 764.11, 764.11, 764.11, 770.98, 770.98, 770.98, 770.98, 770.98, 770.82, 770.82, 770.82, 770.82, 770.82, 774.26, 774.26, 774.26, 774.26, 774.26, 777.25, 777.25, 777.25, 777.25, 777.25, 779.09, 779.09, 779.09, 779.09, 779.09, 785.9, 785.9, 785.9, 785.9, 785.9, 785.15, 785.15, 785.15, 785.15, 785.15, 786.04, 786.04, 786.04, 786.04, 786.04, 786.07, 786.07, 786.07, 786.07, 786.07]
                    
Loading
predicted_tokens_seconds
More
---
config:
    xyChart:
        titleFontSize: 12
        width: 900
        height: 600
    themeVariables:
        xyChart:
            titleColor: "#000000"
---
xychart-beta
    title "llama.cpp bench-server-baseline on Standard_NC4as_T4_v3
 duration=10m 510 iterations"
    y-axis "llamacpp:predicted_tokens_seconds"
    x-axis "llamacpp:predicted_tokens_seconds" 1716311606 --> 1716312234
    line [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 41.06, 41.06, 41.06, 41.06, 41.06, 44.1, 44.1, 44.1, 44.1, 44.1, 28.35, 28.35, 28.35, 28.35, 28.35, 28.6, 28.6, 28.6, 28.6, 28.6, 29.53, 29.53, 29.53, 29.53, 29.53, 31.49, 31.49, 31.49, 31.49, 31.49, 32.51, 32.51, 32.51, 32.51, 32.51, 33.61, 33.61, 33.61, 33.61, 33.61, 34.03, 34.03, 34.03, 34.03, 34.03, 33.82, 33.82, 33.82, 33.82, 33.82, 33.38, 33.38, 33.38, 33.38, 33.38, 33.32, 33.32, 33.32, 33.32, 33.32, 33.15, 33.15, 33.15, 33.15, 33.15, 33.02, 33.02, 33.02, 33.02, 33.02, 32.73, 32.73, 32.73, 32.73, 32.73, 30.46, 30.46, 30.46, 30.46, 30.46, 30.17, 30.17, 30.17, 30.17, 30.17, 30.19, 30.19, 30.19, 30.19, 30.19, 30.36, 30.36, 30.36, 30.36, 30.36, 30.02, 30.02, 30.02, 30.02, 30.02, 29.79, 29.79, 29.79, 29.79, 29.79, 29.97, 29.97, 29.97, 29.97, 29.97, 30.07, 30.07, 30.07, 30.07, 30.07, 30.3, 30.3, 30.3, 30.3, 30.3, 30.33, 30.33, 30.33, 30.33, 30.33, 30.32, 30.32, 30.32, 30.32, 30.32, 30.52, 30.52, 30.52, 30.52, 30.52, 30.68, 30.68, 30.68, 30.68, 30.68, 30.47, 30.47, 30.47, 30.47, 30.47, 30.52, 30.52, 30.52, 30.52, 30.52, 30.63, 30.63, 30.63, 30.63, 30.63, 30.77, 30.77, 30.77, 30.77, 30.77, 30.83, 30.83, 30.83, 30.83, 30.83, 30.88, 30.88, 30.88, 30.88, 30.88, 31.03, 31.03, 31.03, 31.03, 31.03, 31.06, 31.06, 31.06, 31.06, 31.06, 31.02, 31.02, 31.02, 31.02, 31.02, 30.56, 30.56, 30.56, 30.56, 30.56, 30.43, 30.43, 30.43, 30.43, 30.43, 30.11, 30.11, 30.11, 30.11, 30.11, 30.15, 30.15, 30.15, 30.15, 30.15, 30.32, 30.32, 30.32, 30.32, 30.32, 30.4, 30.4, 30.4, 30.4, 30.4, 30.45, 30.45, 30.45, 30.45, 30.45, 30.55, 30.55, 30.55, 30.55, 30.55, 30.32, 30.32, 30.32, 30.32, 30.32, 30.08, 30.08, 30.08, 30.08, 30.08, 30.03, 30.03, 30.03, 30.03, 30.03, 28.9, 28.9, 28.9, 28.9, 28.9, 28.58, 28.58, 28.58, 28.58, 28.58, 28.59, 28.59, 28.59, 28.59, 28.59, 28.59, 28.59, 28.59, 28.59, 28.59, 28.68, 28.68, 28.68, 28.68, 28.68, 28.71, 28.71, 28.71, 28.71, 28.71, 28.87, 28.87, 28.87, 28.87, 28.87, 28.86, 28.86, 28.86, 28.86, 28.86, 28.75, 28.75, 28.75, 28.75, 28.75, 28.77, 28.77, 28.77, 28.77, 28.77, 28.73, 28.73, 28.73, 28.73, 28.73, 28.74, 28.74, 28.74, 28.74, 28.74, 28.76, 28.76, 28.76, 28.76, 28.76]
                    
Loading

Details

kv_cache_usage_ratio

More
---
config:
    xyChart:
        titleFontSize: 12
        width: 900
        height: 600
    themeVariables:
        xyChart:
            titleColor: "#000000"
---
xychart-beta
    title "llama.cpp bench-server-baseline on Standard_NC4as_T4_v3
 duration=10m 510 iterations"
    y-axis "llamacpp:kv_cache_usage_ratio"
    x-axis "llamacpp:kv_cache_usage_ratio" 1716311606 --> 1716312234
    line [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.08, 0.08, 0.08, 0.08, 0.08, 0.28, 0.28, 0.28, 0.28, 0.28, 0.3, 0.3, 0.3, 0.3, 0.3, 0.11, 0.11, 0.11, 0.11, 0.11, 0.16, 0.16, 0.16, 0.16, 0.16, 0.12, 0.12, 0.12, 0.12, 0.12, 0.16, 0.16, 0.16, 0.16, 0.16, 0.13, 0.13, 0.13, 0.13, 0.13, 0.16, 0.16, 0.16, 0.16, 0.16, 0.22, 0.22, 0.22, 0.22, 0.22, 0.24, 0.24, 0.24, 0.24, 0.24, 0.2, 0.2, 0.2, 0.2, 0.2, 0.16, 0.16, 0.16, 0.16, 0.16, 0.35, 0.35, 0.35, 0.35, 0.35, 0.39, 0.39, 0.39, 0.39, 0.39, 0.38, 0.38, 0.38, 0.38, 0.38, 0.2, 0.2, 0.2, 0.2, 0.2, 0.23, 0.23, 0.23, 0.23, 0.23, 0.23, 0.23, 0.23, 0.23, 0.23, 0.18, 0.18, 0.18, 0.18, 0.18, 0.13, 0.13, 0.13, 0.13, 0.13, 0.24, 0.24, 0.24, 0.24, 0.24, 0.14, 0.14, 0.14, 0.14, 0.14, 0.18, 0.18, 0.18, 0.18, 0.18, 0.27, 0.27, 0.27, 0.27, 0.27, 0.2, 0.2, 0.2, 0.2, 0.2, 0.15, 0.15, 0.15, 0.15, 0.15, 0.29, 0.29, 0.29, 0.29, 0.29, 0.19, 0.19, 0.19, 0.19, 0.19, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.18, 0.18, 0.18, 0.18, 0.18, 0.22, 0.22, 0.22, 0.22, 0.22, 0.11, 0.11, 0.11, 0.11, 0.11, 0.17, 0.17, 0.17, 0.17, 0.17, 0.27, 0.27, 0.27, 0.27, 0.27, 0.33, 0.33, 0.33, 0.33, 0.33, 0.32, 0.32, 0.32, 0.32, 0.32, 0.32, 0.32, 0.32, 0.32, 0.32, 0.21, 0.21, 0.21, 0.21, 0.21, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.17, 0.17, 0.17, 0.17, 0.17, 0.39, 0.39, 0.39, 0.39, 0.39, 0.58, 0.58, 0.58, 0.58, 0.58, 0.66, 0.66, 0.66, 0.66, 0.66, 0.65, 0.65, 0.65, 0.65, 0.65, 0.32, 0.32, 0.32, 0.32, 0.32, 0.24, 0.24, 0.24, 0.24, 0.24, 0.22, 0.22, 0.22, 0.22, 0.22, 0.18, 0.18, 0.18, 0.18, 0.18, 0.22, 0.22, 0.22, 0.22, 0.22, 0.11, 0.11, 0.11, 0.11, 0.11, 0.19, 0.19, 0.19, 0.19, 0.19, 0.27, 0.27, 0.27, 0.27, 0.27, 0.13, 0.13, 0.13, 0.13, 0.13, 0.26, 0.26, 0.26, 0.26, 0.26, 0.26, 0.26, 0.26, 0.26, 0.26, 0.15, 0.15, 0.15, 0.15, 0.15, 0.2, 0.2, 0.2, 0.2, 0.2]
                    
Loading
requests_processing
More
---
config:
    xyChart:
        titleFontSize: 12
        width: 900
        height: 600
    themeVariables:
        xyChart:
            titleColor: "#000000"
---
xychart-beta
    title "llama.cpp bench-server-baseline on Standard_NC4as_T4_v3
 duration=10m 510 iterations"
    y-axis "llamacpp:requests_processing"
    x-axis "llamacpp:requests_processing" 1716311606 --> 1716312234
    line [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 7.0, 7.0, 7.0, 7.0, 7.0, 8.0, 8.0, 8.0, 8.0, 8.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 3.0, 3.0, 3.0, 3.0, 3.0, 1.0, 1.0, 1.0, 1.0, 1.0, 4.0, 4.0, 4.0, 4.0, 4.0, 2.0, 2.0, 2.0, 2.0, 2.0, 8.0, 8.0, 8.0, 8.0, 8.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 3.0, 3.0, 3.0, 3.0, 3.0, 8.0, 8.0, 8.0, 8.0, 8.0, 7.0, 7.0, 7.0, 7.0, 7.0, 2.0, 2.0, 2.0, 2.0, 2.0, 5.0, 5.0, 5.0, 5.0, 5.0, 6.0, 6.0, 6.0, 6.0, 6.0, 7.0, 7.0, 7.0, 7.0, 7.0, 6.0, 6.0, 6.0, 6.0, 6.0, 5.0, 5.0, 5.0, 5.0, 5.0, 3.0, 3.0, 3.0, 3.0, 3.0, 6.0, 6.0, 6.0, 6.0, 6.0, 3.0, 3.0, 3.0, 3.0, 3.0, 8.0, 8.0, 8.0, 8.0, 8.0, 3.0, 3.0, 3.0, 3.0, 3.0, 6.0, 6.0, 6.0, 6.0, 6.0, 8.0, 8.0, 8.0, 8.0, 8.0, 5.0, 5.0, 5.0, 5.0, 5.0, 7.0, 7.0, 7.0, 7.0, 7.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 4.0, 4.0, 4.0, 4.0, 4.0, 5.0, 5.0, 5.0, 5.0, 5.0, 6.0, 6.0, 6.0, 6.0, 6.0, 4.0, 4.0, 4.0, 4.0, 4.0, 7.0, 7.0, 7.0, 7.0, 7.0, 5.0, 5.0, 5.0, 5.0, 5.0, 7.0, 7.0, 7.0, 7.0, 7.0, 3.0, 3.0, 3.0, 3.0, 3.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 7.0, 7.0, 7.0, 7.0, 7.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 7.0, 7.0, 7.0, 7.0, 7.0, 8.0, 8.0, 8.0, 8.0, 8.0, 4.0, 4.0, 4.0, 4.0, 4.0, 7.0, 7.0, 7.0, 7.0, 7.0, 8.0, 8.0, 8.0, 8.0, 8.0, 4.0, 4.0, 4.0, 4.0, 4.0, 7.0, 7.0, 7.0, 7.0, 7.0, 6.0, 6.0, 6.0, 6.0, 6.0, 8.0, 8.0, 8.0, 8.0, 8.0, 5.0, 5.0, 5.0, 5.0, 5.0, 6.0, 6.0, 6.0, 6.0, 6.0, 3.0, 3.0, 3.0, 3.0, 3.0, 4.0, 4.0, 4.0, 4.0, 4.0, 7.0, 7.0, 7.0, 7.0, 7.0]
                    
Loading

@ggerganov ggerganov merged commit fcf6538 into ggerganov:master May 21, 2024
58 of 74 checks passed
@github-actions github-actions bot added the ggml changes relating to the ggml tensor library for machine learning label May 21, 2024
Nexesenex added a commit to Nexesenex/croco.cpp that referenced this pull request May 21, 2024
teleprint-me pushed a commit to teleprint-me/llama.cpp that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ggml changes relating to the ggml tensor library for machine learning merge ready indicates that this may be ready to merge soon and is just holding out in case of objections Nvidia GPU Issues specific to Nvidia GPUs Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants