Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove torch GPU dependencies from the Docker.full image #665

Merged
merged 2 commits into from
Apr 2, 2023
Merged

Remove torch GPU dependencies from the Docker.full image #665

merged 2 commits into from
Apr 2, 2023

Conversation

bsilvereagle
Copy link
Contributor

@bsilvereagle bsilvereagle commented Mar 31, 2023 •
edited
Loading

Changes

  • Remove torch GPU dependencies as this is a CPU project

Results

Full Image - 5.7GB reduction in size:

$ podman images
REPOSITORY                           TAG                  IMAGE ID      CREATED         SIZE
<none>                               master               e589ee9cb803  19 minutes ago  7.32 GB
<none>                               bsilvereagle         e1ea3ddecfd8  4 seconds ago   1.62 GB

Maintenance Impacts

  • torch is pinned to version 2.0.0 which is a departure from the README etc which do not pin

@bsilvereagle
Copy link
Contributor Author

@bernatvadell please take a look

prusnak
prusnak requested changes Apr 1, 2023
View reviewed changes
.devops/full.Dockerfile Outdated Show resolved Hide resolved
@prusnak prusnak changed the title Remove torch GPU dependencies Remove torch GPU dependencies from the Docker.full image Apr 1, 2023
@bsilvereagle @prusnak
Remove pinning & use CPU whls directly
9fe1524 
Co-authored-by: Pavol Rusnak <pavol@rusnak.io>
@bsilvereagle bsilvereagle requested a review from prusnak April 2, 2023 21:44
@prusnak prusnak merged commit a0c0516 into ggerganov:master Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsilvereagle @prusnak