wpm : portable unicode tolower #6305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cebtenzzre
added a commit
to nomic-ai/llama.cpp
that referenced
this pull request
Mar 25, 2024
excludes unicodedata.cpp split Signed-off-by: Jared Van Bortel <jared@nomic.ai>
ggerganov
approved these changes
Mar 26, 2024
hodlen
pushed a commit
to hodlen/llama.cpp
that referenced
this pull request
Apr 1, 2024
Also use C locale for ispunct/isspace, and split unicode-data.cpp from unicode.cpp.
hodlen
pushed a commit
to hodlen/llama.cpp
that referenced
this pull request
Apr 3, 2024
Also use C locale for ispunct/isspace, and split unicode-data.cpp from unicode.cpp.
tybalex
pushed a commit
to rubra-ai/tools.cpp
that referenced
this pull request
Apr 17, 2024
Also use C locale for ispunct/isspace, and split unicode-data.cpp from unicode.cpp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a portable implementation of Unicode tolower for BERT embeddings models that use the WPM tokenizer.
We need this because we can't assume that the
en_US.UTF-8locale is available, see #5740 (comment).Wikitext tokenizer diff with this change (same as before):