Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common: llama_load_model_from_url split support #6192
common: llama_load_model_from_url split support #6192
Changes from 9 commits
ddb13ed
7c63644
fbcf2ab
c7d4db3
dc3469e
08a0c13
4fa1c63
8187983
3ba5f2d
b4a2ed8
52d7f44
bdef0ec
4da00c1
34a7665
72d4eb5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here progression of each split will be flushed to stderr concurrently, it can be improved later on, the actual final result is good enough for a first version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the current
gguf-split
implementation, the first file includes tensor data. Probably in future the first split should only contain metadata to trigger the tensor data download in // earlier.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here if one download fails, other will continue in background. I think it's acceptable for the first version ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think, in worst case user can re-run to re-download the missing part. That reminds me about how docker download multiple layers.
In the future we can allow developer to modify this behavior, we can add a new
llama_download_params
to specify:stop_immediate_on_fail
==> true to stop if one part failsn_parallel
==> maximum number of downloads can run in parallelforce_redownload
==> skip checking etag