Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] increase igpu cluster limit #6159

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

abhilash1910
Copy link
Collaborator

@abhilash1910 abhilash1910 commented Mar 19, 2024

The original value of GGML_SYCL_MAX_DEVICES is 16. It can't meet the capability in real test environment.
Because 1 GPU could have 2 device IDs in SYCL: level_zero device and opencl device.
In multiple GPUs case, the max devices will be double.

Extend limit for certain iGPU clusters.
cc @ggerganov @NeoZhangJianyu
feel free to merge after CI pass

Copy link
Contributor

@AidanBeltonS AidanBeltonS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change. Seems suitable for larger clusters

Copy link
Collaborator

@OuadiElfarouki OuadiElfarouki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@abhilash1910
Copy link
Collaborator Author

abhilash1910 commented Mar 20, 2024

sycl tests passing. can be merged cc @ggerganov

@abhilash1910 abhilash1910 merged commit d26e8b6 into ggerganov:master Mar 20, 2024
52 of 54 checks passed
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 1, 2024
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 3, 2024
tybalex pushed a commit to rubra-ai/tools.cpp that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants