cmake : fix VULKAN and ROCm builds #5525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggml-ci
ggml-ci
philiptaron
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
CMake changes look good to me (and mostly refactors) though I am no CMake expert. I tested this through the nix flake (and you can see that the flake builds successfully in CI below.)
$ nix build github:ggerganov/llama.cpp/gg/fix-cmake#{default,rocm,vulkan,cuda,mpi-cpu,mpi-cuda,opencl}
$ echo $?
0
|
@ggerganov you can see that rocm built successfully in https://github.com/ggerganov/llama.cpp/actions/runs/7929857796/job/21650935395?pr=5525 |
|
Thanks for the fix. |
jordankanter
pushed a commit
to jordankanter/llama.cpp
that referenced
this pull request
Mar 13, 2024
* cmake : fix VULKAN and ROCm builds * cmake : fix (cont) * vulkan : fix compile warnings ggml-ci * cmake : fix ggml-ci * cmake : minor ggml-ci
hodlen
pushed a commit
to hodlen/llama.cpp
that referenced
this pull request
Apr 1, 2024
* cmake : fix VULKAN and ROCm builds * cmake : fix (cont) * vulkan : fix compile warnings ggml-ci * cmake : fix ggml-ci * cmake : minor ggml-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ggml-vulkanandggml-rocmtargets - link everything inggmlTODO: