finetune: add missing includes #4871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the missing includes reported by the include-what-you-use tool (iwyu). Refs: ggerganov#4756 Signed-off-by: Daniel Bevenius <daniel.bevenius@gmail.com>
This commit adds comments to the includes in finetune.cpp that currently don't have comments containing what they include. Signed-off-by: Daniel Bevenius <daniel.bevenius@gmail.com>
This commit sorts the includes in finetune.cpp according to the include-what-you-use tool. The motivation for sorting is that it might make it easier in the furture to just copy and paste the output from iwyu into the source and also to make it easier to see what is missing. Signed-off-by: Daniel Bevenius <daniel.bevenius@gmail.com>
|
We always put local headers before the rest. |
Ah sorry about that, I think I misinterpreted your comment in #4756 (comment) which was the reason for opening this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the missing includes reported by the include-what-you-use tool (iwyu).
Refs: #4756