Fix crash for 65B model after recent pre-allocated memory change #485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash which started with #473 for me when using the 65B model and
-c 2048
.On master, I get a crash in the call to
std::vector::resize()
:It seems like it is trying to resize the vector to an absurd number of elements:
After this change, it no longer crashes:
With a breakpoint right after the successful
resize()
call, I can inspect the vector'ssize()
and it looks reasonable (about 5 GB):