Cloud-V CI for RISC-V builds #3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
reviewed
Sep 14, 2023
Makefile
Outdated
Comment on lines
289
to
298
| MK_CFLAGS += -march=rv64gcv -mabi=lp64d | ||
| MK_CXXFLAGS += -march=rv64gcv -mabi=lp64d | ||
| CFLAGS += -march=rv64gcv -mabi=lp64d | ||
| CXXFLAGS += -march=rv64gcv -mabi=lp64d |
Makefile
Outdated
Comment on lines
23
to
24
| CC := riscv64-unknown-linux-gnu-gcc | ||
| CXX := riscv64-unknown-linux-gnu-g++ |
There was a problem hiding this comment.
Suggested change
| CC := riscv64-unknown-linux-gnu-gcc | |
| CXX := riscv64-unknown-linux-gnu-g++ | |
| CC := riscv64-unknown-linux-gnu-gcc | |
| CXX := riscv64-unknown-linux-gnu-g++ |
|
@ggerganov I have replaced my Makefile with your upstream Makefile which is in master branch right now. So its good to go. |
mmhus
reviewed
Sep 15, 2023
| @@ -49,7 +49,7 @@ test: $(TEST_TARGETS) | |||
| ./$$test_target $(CURDIR)/models/ggml-vocab-llama.gguf; \ | |||
| elif [ "$$test_target" = "tests/test-tokenizer-0-falcon" ]; then \ | |||
| continue; \ | |||
| elif [ "$$test_target" = "tests/test-tokenizer-1" ]; then \ | |||
There was a problem hiding this comment.
@alitariq4589 Are these changes correct?
pkrmf
pushed a commit
to morlockstudios-com/llama.cpp
that referenced
this pull request
Sep 26, 2023
* Added Cloud-V File * Replaced Makefile with original one --------- Co-authored-by: moiz.hussain <moiz.hussain@10xengineers.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I have added a CI file (.devops/cloud-v-pipeline) for testing llama.cpp on Cloud-V platform. The build will be able to run on RISC-V vector extension-enabled QEMU. We also have multiple RISC-V boards on https://dash.cloud-v.co as runners.
The details about this PR CI build can be seen here: https://cloud-v.co:8443/view/Vector%20processing/job/llama.cpp/34/
For automated builds, the credentials for @ggerganov have been created. The owner of the repository will have to just create a webhook for the repository in the repository settings and add the token of github access (limited to repo) in Cloud-V the info about both of which can be found in this link. For triggering builds manually for this repository, you can also use this CI build which is open to anyone for building ggerganov/llama.cpp repository on RISC-V runner in Cloud-V.