CMake: add relocatable Llama package #2960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Take a look at #2886, it's possibly related. |
These do not (to me at least) seem to be related. The change I have made builds a Llama CMake package, whereas #2886 allows |
ggerganov
approved these changes
Sep 2, 2023
Resolved conflicts in CMakeLists.txt.
|
Anyone can merge this please? Thank you! |
pkrmf
pushed a commit
to morlockstudios-com/llama.cpp
that referenced
this pull request
Sep 26, 2023
* Keep static libs and headers with install * Add logic to generate Config package * Use proper build info * Add llama as import library * Prefix target with package name * Add example project using CMake package * Update README * Update README * Remove trailing whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for a relocatable CMake package. This includes several enhancements:
lib/cmake/Llama. This generates the requiredLlamaConfig.cmakeandLlamaConfigVersion.cmakefiles.examples/main-cmake-pkg, for testing/demonstrating these capabilities. This application builds main but using the installed Llama CMake package.This will enable application developers using CMake a much improved way to add llama as a link target.