Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: add support for CUDA in docker #1461

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

canardleteer
Copy link
Contributor

@canardleteer canardleteer commented May 15, 2023

Assuming one has the nvidia-container-toolkit installed on Linux, or is using a GPU enabled cloud, cuBLAS should be accessible inside the container.

I'm not very familiar with Github Actions, nor the available execution environments available on GitHub. I wouldn't suggest pre-building these and putting them in the registry, unless there's a CI path for them.

I'm not too sure what the right path for putting these into a registry is. But I did want to contribute so people could try it locally!

@canardleteer
Copy link
Contributor Author

canardleteer commented May 15, 2023

I should add a note, I haven't been able to get the:

-p "Building a website can be done in 10 simple steps:"

...part of the examples in README.md to work for me in Linux because of string escaping (both the original and these new examples). I have tested it with --random-prompt however and it works fine for me with BLAS = 1 and nvidia-smi showing memory usage by llama.cpp.

I just wanted to keep it in line with the other Docker examples.

@canardleteer canardleteer force-pushed the feat/docker-cuda branch 3 times, most recently from f4ac04e to fdad997 Compare May 15, 2023 01:25
Copy link
Collaborator

@JohannesGaessler JohannesGaessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking something like this would be nice to have but ultimately prioritized fixing the current issues like memory management first. Thanks.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@JohannesGaessler JohannesGaessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not particularly knowledgeable about docker but to me it looks like everything is in order now.

@canardleteer
Copy link
Contributor Author

Fixed a trailing white space error from the Makefile (and installed editorconfig for the future).

@canardleteer
Copy link
Contributor Author

Could I get another run of CI on this?

Copy link

@dkarlovi dkarlovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes to make it slightly less confusing, otherwise LGTM, it works.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@deep-pipeline
Copy link

This looks really useful for integration/deployment of llama.cpp into docker hosted services on cloud!

Is there anything (apart from the vast amount of other activity ;-) ) holding up this being merged now?

Um, on which note, I see that total open pull-requests, not issues(!), has risen from, iirc, 53 to 65 since I last checked in.. which is kinda great but also kinda scary because of implication for level of stress on supervision bandwidth..

@canardleteer
Copy link
Contributor Author

The upstream Makefile now has a conflict that I will need to resolve, and will do so when I get a chance.

@JohannesGaessler
Copy link
Collaborator

I didn't merge this PR because I wanted someone else to check it as well; as I said, I'm not very knowledgeable about Docker.

@canardleteer
Copy link
Contributor Author

I have rebased on the latest changes in master. A second set of eyes on my changes + a pipeline run would alleviate my concerns about those changes :)

@ggerganov ggerganov requested a review from prusnak June 10, 2023 08:13
Copy link
Owner

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait for an extra approve before merging as I'm unfamiliar with Docker

@deep-pipeline
Copy link

Hi folks, just a very gentle nudge again on this front - last time I checked here the total open pull-requests on this repo were about 65, a month later they are over 80.. as before I'm worried that more project approval/supervision bandwidth needs to be allocated to clear backlog a bit so older 'finished' PRs like this don't age stuck in limbo, suffer new integration issues and need revisiting..

It would be a shame if good work gets buried/lost/stuck with PRs not folded into main (and if sprawling PR numbers mean stale PRs are not being explicitly closed or duplicates being coalesced).

The docker support stuff ought to be relatively independent of other changes - maybe worth a final CI check and folding in this one now - any problems for nvidia-docker use can be sorted via bug-reports by people trying it (who currently don't have the easy option).

Best, M.

@ggerganov ggerganov merged commit 84525e7 into ggerganov:master Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants