CLI args use - instead of _, backwards compatible #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sw
reviewed
May 12, 2023
JohannesGaessler
force-pushed
the
consistent-cli-args
branch
from
3e435cb to
e3c7dcf
Compare
sw
approved these changes
May 12, 2023
|
Someone had to do it! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1375 someone suggested using
--gpu-layersinstead of--gpu_layers. I had simply picked an underscore because I looked at what a random other argument was using. On master CLI arguments use "-" and "_" in an inconsistent way. This PR changes all CLI arguments to use "-". When a CLI arg contains "_" it is automatically converted to "-" to preserve backwards compatibility.