Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vulkan: Use macros to make the mat mul pipeline creation more concise #10259

Merged
merged 1 commit into from
Nov 13, 2024
Merged

vulkan: Use macros to make the mat mul pipeline creation more concise #10259

merged 1 commit into from
Nov 13, 2024
+138 −454

Conversation

jeffbolznv
Copy link
Collaborator

Also add vk_matmul_pipeline2 to hold f16/f32 accumulator versions of a pipeline. This isn't really used yet.

Split out from #10206.

@jeffbolznv
vulkan: Use macros to make the mat mul pipeline creation more concise
ad4a165 
Also add vk_matmul_pipeline2 to hold f16/f32 accumulator versions of a
pipeline. This isn't really used yet.
@github-actions github-actions bot added Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels Nov 12, 2024
0cc4m
0cc4m approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@0cc4m 0cc4m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you. I'll make a PR soon with the implementation of the mul_mm shader with the two accumulators.

@0cc4m 0cc4m merged commit 66798e4 into ggerganov:master Nov 13, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0cc4m 0cc4m 0cc4m approved these changes

Assignees
No one assigned
Labels
ggml changes relating to the ggml tensor library for machine learning Vulkan Issues specific to the Vulkan backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffbolznv @0cc4m