Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples : ggwave-to-file Fixes #98

Merged
merged 2 commits into from
Jul 23, 2023
Merged

examples : ggwave-to-file Fixes #98

merged 2 commits into from
Jul 23, 2023

Conversation

guilt
Copy link
Contributor

@guilt guilt commented Jul 23, 2023

This change does two things:

  • On Windows, set the /dev/stdout device equivalent to a file instead, which is audio.wav; Writing to CON, CONOUT$ does not work with redirection. Tested a bunch of things, this is what works now.
  • Allow a user to specify a different filename to write to, instead of printing to console or audio.wav.

@guilt
Copy link
Contributor Author

guilt commented Jul 23, 2023

@ggerganov Please review. I am using this to test ggwave-to-file and ggwave-from-file on Windows.

@ggerganov ggerganov merged commit c2716d8 into ggerganov:master Jul 23, 2023
@guilt
Copy link
Contributor Author

guilt commented Jul 23, 2023

@ggerganov Thank you. I updated the comments for this PR to be in sync with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants