Now ggwave python library accepts bytes as input to encode #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ggerganov please check this out, cause i don't want people to install my fork of ggwave to use my app. I think you're too busy with other projects |
ggerganov
approved these changes
Nov 16, 2024
|
Yeeeah i feal so great when I could contribute into some big projects even a little. Now time to update on pypi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a small change to cython file that encodes the payload only if it's a string. Thus, you can send raw bytes as ggwave messages.
I needed it so much so I made a little contribution.
Thank you for this library, it's great!