Skip to content

Re-add support for memoryless storage on A7 #8725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
opstic wants to merge 6 commits into
base: trunk
Choose a base branch
from
+10 −1
Open

Re-add support for memoryless storage on A7 #8725

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
df6d29e
Re-add support for memoryless storage on A7
opstic Dec 13, 2025
a4bc3f5
`cargo fmt`
opstic Dec 13, 2025
fa90300
Link to PR
opstic Dec 13, 2025
2881341
Improve comment for explanation
opstic Dec 18, 2025
2cd96df
Resolve conflict
opstic Dec 18, 2025
44d0594
Merge branch 'trunk' into a7-memoryless
opstic Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion wgpu-hal/src/metal/adapter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -960,8 +960,17 @@ impl super::PrivateCapabilities {
|| (version.at_least((10, 15), (14, 0), (16, 0), (1, 0), os_type)
&& device.supports_shader_barycentric_coordinates()),
// https://developer.apple.com/metal/Metal-Feature-Set-Tables.pdf#page=3
// See https://github.com/gfx-rs/wgpu/pull/8725 for more details
supports_memoryless_storage: metal4
|| (family_check && device.supports_family(MTLGPUFamily::Apple2)),
|| if family_check {
// Apple A7 (MTLGPUFamily::Apple1) has been tested to have support.
device.supports_family(MTLGPUFamily::Apple1)
} else {
// macOS: Always rely on family check
// iOS/tvOS: API added in 10.0
// visionOS: Always rely on family check
version.at_least(OS_NOT_SUPPORT, (10, 0), (10, 0), OS_NOT_SUPPORT, os_type)
},
supported_vertex_amplification_factor: {
let mut factor = 1;
// https://developer.apple.com/metal/Metal-Feature-Set-Tables.pdf#page=8
Expand Down
Loading