Convert error scopes to use thread-local guards #8595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@kpreid could you take a look at the docs and the handling of the unwind behavior? I'm not sure I made all the right decisions, but this seems alright. |
cwfitzgerald
force-pushed
the
cw/error-scope-guard
branch
from
fc02362 to
7a98d46
Compare
cwfitzgerald
commented
Nov 30, 2025
cwfitzgerald
force-pushed
the
cw/error-scope-guard
branch
from
7a98d46 to
bfe9c3a
Compare
kpreid
suggested changes
Dec 1, 2025
cwfitzgerald
force-pushed
the
cw/error-scope-guard
branch
from
24df8d0 to
f55e365
Compare
Co-authored-by: Kevin Reid <kpreid@switchb.org>
cwfitzgerald
force-pushed
the
cw/error-scope-guard
branch
from
f55e365 to
62d8c80
Compare
kpreid
approved these changes
Dec 2, 2025
ErichDonGubler
approved these changes
Dec 2, 2025
Member
|
Will let @cwfitzgerald merge. |
cwfitzgerald
commented
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Closes #5375 for good this time.
Description
Converts errors scopes to use a guard and adds infrastructure to validate against out-of-order popping and such.
Testing
Added testing of the various popping behavior.
Squash or Rebase?
Squishsquash I'm taking a bath.