-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add multiview limits and tests #8206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Add multiview limits and tests #8206
Conversation
@cwfitzgerald I left a comment about this in matrix but it got hidden by newer messages. Is it a bad idea to add another multi view related field to a render pass descriptor? This might be a topic worth bringing up in a meeting, I'm not sure. I'm just hesitant to assume that's fine because if I'm wrong then I will have refactored every use of render passes in this entire repo :) Not urgent of course EDIT: This has been answered |
…ue to bitmask limitation
…amples multiview fields
I'm going to explicitly ping @crowlKats since I made changes to the deno API that I'm not sure make sense. I tried to copy from where I saw |
…ure gets 255 no matter what.
Connections
Addresses #7196 and #8138
Description
Adds new limits and testing for multiview, add support for more backends (also in naga), add new multiview bitmask renderpass descriptor field for selecting which layers to render to in a single pass.
CURRENTLY WAITING ON #8110
Marking as open because its had progress made and I think this is about what it will look like when complete, even though its completely broken at the moment. Also because I want to get it in the pipeline sooner rather than later. Just the following remaining.
TODO:
Testing
There are tests
Squash or Rebase?
Squash
Checklist
cargo fmt
.taplo format
.cargo clippy --tests
. If applicable, add:--target wasm32-unknown-unknown
cargo xtask test
to run tests.CHANGELOG.md
entry.