Additional validation of buffer-texture copies #7948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleiserson
force-pushed
the
buffer-texture-copy-validation
branch
from
505645e to
859c787
Compare
6 tasks
andyleiserson
force-pushed
the
buffer-texture-copy-validation
branch
from
fe9db5a to
26933e5
Compare
1 task
Contributor
Author
|
This comment previously noted which commits belonged to this PR vs. #7935, but that no longer applies since the other PR has been merged and this one rebased. |
teoxoy
reviewed
Jul 22, 2025
teoxoy
reviewed
Jul 22, 2025
andyleiserson
force-pushed
the
buffer-texture-copy-validation
branch
from
3e2c500 to
22efde3
Compare
teoxoy
approved these changes
Jul 23, 2025
andyleiserson
added a commit
to andyleiserson/wgpu
that referenced
this pull request
Jul 29, 2025
This fixes a regression introduced by gfx-rs#7948.
6 tasks
andyleiserson
added a commit
to andyleiserson/wgpu
that referenced
this pull request
Jul 29, 2025
This fixes a regression introduced by gfx-rs#7948. However, it makes it possible to reach a panic in initialize_buffer_memory if the copy requires initializing a region of memory that is not 4B aligned.
andyleiserson
added a commit
to andyleiserson/wgpu
that referenced
this pull request
Jul 29, 2025
This fixes a regression introduced by gfx-rs#7948. However, it makes it possible to reach a panic in initialize_buffer_memory if the copy requires initializing a region of memory that is not 4B aligned.
6 tasks
andyleiserson
added a commit
to andyleiserson/wgpu
that referenced
this pull request
Jul 30, 2025
This fixes a regression introduced by gfx-rs#7948. However, it makes it possible to reach a panic in initialize_buffer_memory if the copy requires initializing a region of memory that is not 4B aligned.
teoxoy
pushed a commit
that referenced
this pull request
Jul 30, 2025
* Restore allowance of unaligned buffer-texture copies This fixes a regression introduced by #7948. However, it makes it possible to reach a panic in initialize_buffer_memory if the copy requires initializing a region of memory that is not 4B aligned. * Fix CopyT2T of multi-layer depth/stencil textures * Adjust test list
sharmajai
pushed a commit
to sharmajai/wgpu
that referenced
this pull request
Oct 12, 2025
* Additional validation of buffer-texture copies Fixes gfx-rs#7936, but leaves a TODO for gfx-rs#7947 * Skip tests failing on dx12 * Update comments and change unwrap_or to expect
sharmajai
pushed a commit
to sharmajai/wgpu
that referenced
this pull request
Oct 12, 2025
* Restore allowance of unaligned buffer-texture copies This fixes a regression introduced by gfx-rs#7948. However, it makes it possible to reach a panic in initialize_buffer_memory if the copy requires initializing a region of memory that is not 4B aligned. * Fix CopyT2T of multi-layer depth/stencil textures * Adjust test list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some more buffer-texture copy validation. I am declaring that this fixes #7936, although there are still problems with buffer-texture copies, see #7946 and #7947.
This PR enforces:
Testing
Enables a sampling of relevant CTS tests, but some of the tests still have a mix of passing and failing variants and I didn't try to exhaustively list every passing case in
test.lst.Squash or Rebase? Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.